Merge pull request #27 from elbachir-one/main

Adding a Check for XGetWindowAttributes failure.

1 files changed, 20 insertions, 11 deletions

diff --git a/src/sxwm.c b/src/sxwm.c
index a2dfdcd..e7161d9 100644
--- a/src/sxwm.c
+++ b/src/sxwm.c
@@ -1527,30 +1527,39 @@ void toggle_floating(void)
 		return;
 	}
 
-	focused->floating = !focused->floating;
 	if (focused->fullscreen) {
 		focused->fullscreen = False;
 		tile();
 		XSetWindowBorderWidth(dpy, focused->win, user_config.border_width);
 	}
 
+	focused->floating = !focused->floating;
+
 	if (focused->floating) {
 		XWindowAttributes wa;
-		XGetWindowAttributes(dpy, focused->win, &wa);
-		focused->x = wa.x;
-		focused->y = wa.y;
-		focused->w = wa.width;
-		focused->h = wa.height;
-
-		XConfigureWindow(
-		    dpy, focused->win, CWX | CWY | CWWidth | CWHeight,
-		    &(XWindowChanges){.x = focused->x, .y = focused->y, .width = focused->w, .height = focused->h});
+		if (XGetWindowAttributes(dpy, focused->win, &wa)) {
+			focused->x = wa.x;
+			focused->y = wa.y;
+			focused->w = wa.width;
+			focused->h = wa.height;
+
+			XConfigureWindow(
+				dpy, focused->win,
+				CWX | CWY | CWWidth | CWHeight,
+				&(XWindowChanges){
+					.x = focused->x,
+					.y = focused->y,
+					.width = focused->w,
+					.height = focused->h
+				}
+			);
+		}
 	}
 
 	tile();
 	update_borders();
 
-	/* floating windows are on top */
+	/* Raise and refocus floating window */
 	if (focused->floating) {
 		XRaiseWindow(dpy, focused->win);
 		XSetInputFocus(dpy, focused->win, RevertToPointerRoot, CurrentTime);